fix: Skip issue matching check for thirdparty build dependency librar… #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies. We do not control them. Signed-off-by: ebadiere <[email protected]>
quiet-node
requested changes
Sep 16, 2024
quiet-node
reviewed
Sep 19, 2024
2 tasks
… in the repository and not matching PRs with issues from third party projects. Signed-off-by: ebadiere <[email protected]>
|
quiet-node
approved these changes
Oct 8, 2024
nathanklick
reviewed
Oct 8, 2024
nathanklick
approved these changes
Oct 8, 2024
ebadiere
deleted the
2988-PR-check-ignore-issues-check-external-projects
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2990 +/- ##
==========================================
- Coverage 89.54% 84.83% -4.71%
==========================================
Files 56 59 +3
Lines 3796 3937 +141
Branches 775 786 +11
==========================================
- Hits 3399 3340 -59
- Misses 350 357 +7
- Partials 47 240 +193
Flags with carried forward coverage won't be shown. Click here to find out more. |
ebadiere
added a commit
that referenced
this pull request
Oct 8, 2024
#2990) * fix: Skip issue matching check for thirdparty build dependency libraries. We do not control them. Signed-off-by: ebadiere <[email protected]> * fix: Now validates PRs listed in description by matching contributors in the repository and not matching PRs with issues from third party projects. Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]>
ebadiere
added a commit
that referenced
this pull request
Oct 9, 2024
…82.0 (#3076) * fix: upgrade @graphprotocol/graph-cli from 0.81.0 to 0.82.0 Snyk has created this PR to upgrade @graphprotocol/graph-cli from 0.81.0 to 0.82.0. See this package in npm: @graphprotocol/graph-cli See this project in Snyk: https://app.snyk.io/org/json-rpc-relay/project/24dd80bc-cab7-4d83-83d7-a604d57322e3?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: ebadiere <[email protected]> * fix: Skip issue matching check for thirdparty build dependency librar… (#2990) * fix: Skip issue matching check for thirdparty build dependency libraries. We do not control them. Signed-off-by: ebadiere <[email protected]> * fix: Now validates PRs listed in description by matching contributors in the repository and not matching PRs with issues from third party projects. Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]> * fix: SDKClient timeouts are not getting logged with requestIds. (#3061) * fix: Enhanced logged warning to include SDKClient error message and bumped up SDK_REQUEST_TIMEOUT for CI. Signed-off-by: ebadiere <[email protected]> * fix: Removed the increate in sdkClient timeout. Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]> Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Eric Badiere <[email protected]>
konstantinabl
pushed a commit
that referenced
this pull request
Oct 15, 2024
#2990) * fix: Skip issue matching check for thirdparty build dependency libraries. We do not control them. Signed-off-by: ebadiere <[email protected]> * fix: Now validates PRs listed in description by matching contributors in the repository and not matching PRs with issues from third party projects. Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]>
konstantinabl
pushed a commit
that referenced
this pull request
Oct 15, 2024
…82.0 (#3076) * fix: upgrade @graphprotocol/graph-cli from 0.81.0 to 0.82.0 Snyk has created this PR to upgrade @graphprotocol/graph-cli from 0.81.0 to 0.82.0. See this package in npm: @graphprotocol/graph-cli See this project in Snyk: https://app.snyk.io/org/json-rpc-relay/project/24dd80bc-cab7-4d83-83d7-a604d57322e3?utm_source=github&utm_medium=referral&page=upgrade-pr Signed-off-by: ebadiere <[email protected]> * fix: Skip issue matching check for thirdparty build dependency librar… (#2990) * fix: Skip issue matching check for thirdparty build dependency libraries. We do not control them. Signed-off-by: ebadiere <[email protected]> * fix: Now validates PRs listed in description by matching contributors in the repository and not matching PRs with issues from third party projects. Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]> * fix: SDKClient timeouts are not getting logged with requestIds. (#3061) * fix: Enhanced logged warning to include SDKClient error message and bumped up SDK_REQUEST_TIMEOUT for CI. Signed-off-by: ebadiere <[email protected]> * fix: Removed the increate in sdkClient timeout. Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]> --------- Signed-off-by: ebadiere <[email protected]> Co-authored-by: snyk-bot <[email protected]> Co-authored-by: Eric Badiere <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip issue check for thirdparty libraries. We do not control them.
Related issue(s):
Fixes #2988